-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the current year selection in December #1228
Open
JammingBen
wants to merge
1
commit into
nathanreyes:master
Choose a base branch
from
JammingBen:fix-current-year-select
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
@nathanreyes, can we have a review & merge. |
dschmidt
added a commit
to owncloud/web
that referenced
this pull request
Dec 16, 2022
dschmidt
added a commit
to owncloud/web
that referenced
this pull request
Dec 20, 2022
dschmidt
added a commit
to owncloud/web
that referenced
this pull request
Dec 20, 2022
dschmidt
added a commit
to owncloud/web
that referenced
this pull request
Dec 22, 2022
dschmidt
added a commit
to owncloud/web
that referenced
this pull request
Dec 22, 2022
JammingBen
pushed a commit
to owncloud/web
that referenced
this pull request
Jan 2, 2023
@JammingBen Might need to rework this against the v3.0.3 release since things have been moved around. Ref: https://github.com/nathanreyes/v-calendar/blob/v3.0.3/src/use/calendarNav.ts#L85 |
There's still no conflict with the target branch - can we have this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the current year could not be selected when using December as
min-date
.Fixes #1131