Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent lock expiration date slider from resetting itself #79

Closed
aahna-ashina opened this issue Aug 12, 2022 · 4 comments
Closed

Prevent lock expiration date slider from resetting itself #79

aahna-ashina opened this issue Aug 12, 2022 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aahna-ashina
Copy link
Member

aahna-ashina commented Aug 12, 2022

https://app.dework.xyz/nation3/app-2?taskId=0554bc64-e2b2-4161-90b5-75997aaf3891

A bug causes the "Lock expiration date" slider at https://app.nation3.org/lock to automatically adjust itself to the original date after a few seconds, which is causing trouble for users interacting with the app:

lock_expiration_date

How to reproduce:

  1. Go to https://app.nation3.org/lock
  2. Adjust the slider, then wait for ~10 seconds

If you are having trouble reproducing this behavior, it could be that this bug only happens for users that have already locked $NATION. If that's the case, you can obtain some test tokens at https://goerli.balancer.fi/#/trade/ether/0x333A4823466879eeF910A04D473505da62142069

@aahna-ashina aahna-ashina added bug Something isn't working good first issue Good for newcomers labels Aug 12, 2022
@aahna-ashina aahna-ashina moved this to 🔖 Ready in 📱Citizen App Aug 12, 2022
@tayyabmh
Copy link
Contributor

So it does not happen to me when I try to leave the "lock" at 1 year for 0 locked $NATION... Now I'm trying to lock in Goerli $NATION tokens but it's not letting me because it says "Wrong Network" so likely need to fix that as an issue as well on Goerli.

Will pull down the code and take a look in a bit.

@aahna-ashina
Copy link
Member Author

So it does not happen to me when I try to leave the "lock" at 1 year for 0 locked $NATION... Now I'm trying to lock in Goerli $NATION tokens but it's not letting me because it says "Wrong Network" so likely need to fix that as an issue as well on Goerli.

Will pull down the code and take a look in a bit.

@tayyabmh To configure the development server to use Goerli instead of Mainnet, you need to add the Goerli variables: https://github.com/nation3/app/blob/main/ui/README.md#run-the-ui-locally

cp .env.goerli .env.local

@tayyabmh
Copy link
Contributor

Yes, I figured that out! Opened up PR#84.

Seems to be something failing, I can look into it. Unless this has already been solved.

@aahna-ashina
Copy link
Member Author

#84

@aahna-ashina aahna-ashina moved this from 🔖 Ready to ✅ Done in 📱Citizen App Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

2 participants