Optional implicit waits #43

Merged
merged 7 commits into from Oct 2, 2013

Conversation

Projects
None yet
2 participants
@tmertens
Contributor

tmertens commented Sep 6, 2013

This resolves the optional implicit waits portion of Issue #41. Simply add the following to your test code (e.g. spec_helper.rb or some other place) to enable implicit waits for the has_ and has_no_ methods in SitePrism.

SitePrism.configure do |config|
  config.use_implicit_waits = true
end

Note I used the name "use_implicit_waits" instead of "existence_check_should_wait" because it seemed more generic in case it is applied to other queries.

@tmertens

This comment has been minimized.

Show comment
Hide comment
@tmertens

tmertens Sep 11, 2013

Contributor

Added documentation.

Contributor

tmertens commented Sep 11, 2013

Added documentation.

@natritmeyer

This comment has been minimized.

Show comment
Hide comment
@natritmeyer

natritmeyer Sep 18, 2013

Owner

I'll get to this next week :)

Owner

natritmeyer commented Sep 18, 2013

I'll get to this next week :)

@tmertens

This comment has been minimized.

Show comment
Hide comment
@tmertens

tmertens Sep 24, 2013

Contributor

👍

Contributor

tmertens commented Sep 24, 2013

👍

@natritmeyer natritmeyer merged commit fdd380c into natritmeyer:master Oct 2, 2013

1 check passed

default The Travis CI build passed
Details
@natritmeyer

This comment has been minimized.

Show comment
Hide comment
Owner

natritmeyer commented Oct 2, 2013

Thanks @tmertens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment