Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional implicit waits #43

Merged
merged 7 commits into from Oct 2, 2013
Merged

Optional implicit waits #43

merged 7 commits into from Oct 2, 2013

Conversation

@tmertens
Copy link
Contributor

@tmertens tmertens commented Sep 6, 2013

This resolves the optional implicit waits portion of Issue #41. Simply add the following to your test code (e.g. spec_helper.rb or some other place) to enable implicit waits for the has_ and has_no_ methods in SitePrism.

SitePrism.configure do |config|
  config.use_implicit_waits = true
end

Note I used the name "use_implicit_waits" instead of "existence_check_should_wait" because it seemed more generic in case it is applied to other queries.

@tmertens
Copy link
Contributor Author

@tmertens tmertens commented Sep 11, 2013

Added documentation.

@natritmeyer
Copy link
Owner

@natritmeyer natritmeyer commented Sep 18, 2013

I'll get to this next week :)

@tmertens
Copy link
Contributor Author

@tmertens tmertens commented Sep 24, 2013

👍

@natritmeyer natritmeyer merged commit fdd380c into natritmeyer:master Oct 2, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@natritmeyer
Copy link
Owner

@natritmeyer natritmeyer commented Oct 2, 2013

Thanks @tmertens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.