Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd storage type mismatch #24

Closed
qugq0228 opened this issue Mar 12, 2021 · 2 comments · Fixed by #25
Closed

crd storage type mismatch #24

qugq0228 opened this issue Mar 12, 2021 · 2 comments · Fixed by #25

Comments

@qugq0228
Copy link

qugq0228 commented Mar 12, 2021

when i create a stream crd and set the storage is "file" ,then i find the stream storage is "Memory".
image
image

@JackZxj
Copy link
Contributor

JackZxj commented Mar 15, 2021

Here is the reason.

switch spec.Storage {
case "file":
opts = append(opts, jsm.MemoryStorage())
case "memory":
opts = append(opts, jsm.FileStorage())
}

1 similar comment
@JackZxj
Copy link
Contributor

JackZxj commented Mar 15, 2021

Here is the reason.

switch spec.Storage {
case "file":
opts = append(opts, jsm.MemoryStorage())
case "memory":
opts = append(opts, jsm.FileStorage())
}

JackZxj added a commit to JackZxj/nack that referenced this issue Mar 15, 2021
variadico pushed a commit that referenced this issue Mar 15, 2021
Currently, we have spec.Storage("file") mapped to jsm.MemoryStorage and
spec.Storage("memory") mapped to jsm.FileStorage.  These should be swapped.

Fix #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants