Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the values of file and memory storage options #25

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

JackZxj
Copy link
Contributor

@JackZxj JackZxj commented Mar 15, 2021

Currently, we have spec.Storage("file") mapped to jsm.MemoryStorage and
spec.Storage("memory") mapped to jsm.FileStorage. These should be swapped.

Fix #24

@variadico variadico self-requested a review March 15, 2021 17:25
@variadico variadico changed the title Exchange two options for Stream Swap the values of file and memory storage options Mar 15, 2021
Copy link
Contributor

@variadico variadico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just cleared up the PR description and title a little.
Thanks!

@variadico variadico merged commit dd075bd into nats-io:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crd storage type mismatch
2 participants