Skip to content

Commit

Permalink
Improve error handling
Browse files Browse the repository at this point in the history
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
  • Loading branch information
Jarema committed Jun 1, 2023
1 parent 92af040 commit a8adeb7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions server/consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -3267,7 +3267,6 @@ func (o *consumer) getNextMsg() (*jsPubMsg, uint64, error) {
return pmsg, 1, err
}

var lastErr error
// if we have filters, iterate over filters and optimize by buffering found messages.
for _, filter := range o.subjf {
if filter.nextSeq < o.sseq {
Expand Down Expand Up @@ -3323,23 +3322,24 @@ func (o *consumer) getNextMsg() (*jsPubMsg, uint64, error) {
// Grab next message applicable to us.
// Sort sequences first, to grab the first message.
filter := o.subjf[0]
err := filter.err
// This means we got a message in this subject fetched.
if filter.pmsg != nil {
filter.currentSeq = filter.nextSeq
o.sseq = filter.currentSeq
returned := filter.pmsg
filter.pmsg = nil
return returned, 1, filter.err
return returned, 1, err
}
if filter.err == ErrStoreEOF {
if err == ErrStoreEOF {
o.updateSkipped(filter.nextSeq)
}

// set o.sseq to the first subject sequence
if filter.nextSeq > o.sseq {
o.sseq = filter.nextSeq
}
return nil, 0, lastErr
return nil, 0, err
}

// Will check for expiration and lack of interest on waiting requests.
Expand Down

0 comments on commit a8adeb7

Please sign in to comment.