Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tilde support for leafnode credentials #1148

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

variadico
Copy link
Contributor

Currently, the leafnode configuration doesn't expand the ~ character to the user's home directory. This change allows users to use ~ in the configuration file when declaring the path to their credentials.

leafnodes {
  remotes [
    {
      url: nats-leaf://127.0.0.1:2222
      account: foobar
      credentials: ~/my.creds
    }
  ]
}

Signed-off-by: Jaime Piña jaime@synadia.com
/cc @nats-io/core

Signed-off-by: Jaime Piña <jaime@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@derekcollison derekcollison merged commit 0a0ff2a into master Oct 2, 2019
@derekcollison derekcollison deleted the add-tilde-support branch October 2, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants