Add a no_auth_user #1363
Merged
Add a no_auth_user #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
reviewed
Apr 30, 2020
This configuration allows to refer to a configured user to be used when the connection provides no credentials. Signed-off-by: Matthias Hanel <mh@synadia.com>
matthiashanel
force-pushed
the
default_user
branch
from
423cef5
to
b074c94
Compare
derekcollison
approved these changes
May 5, 2020
| @@ -410,8 +410,10 @@ func validateOptions(o *Options) error { | |||
| if err := validateLeafNode(o); err != nil { | |||
| return err | |||
| } | |||
| // Check that gateway is properly configured. Returns no error | |||
There was a problem hiding this comment.
@derekcollison Good find. Mind if I add it back in with the change that calls validateOptions after reload?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a no_auth_user as discussed.
To simplify error checking, I decided to do a post parsing error pass.
Reason being, we have multiple sections where users can be configured (multiple accounts as well authorization block).
Signed-off-by: Matthias Hanel mh@synadia.com