Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve access to secrets and a few other issues #3967

Merged
merged 1 commit into from
Mar 15, 2023
Merged

resolve access to secrets and a few other issues #3967

merged 1 commit into from
Mar 15, 2023

Conversation

ripienaar
Copy link
Contributor

No description provided.

@ripienaar
resolve access to secrets and a few other issues
2e362fe 
Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar ripienaar requested a review from a team as a code owner March 15, 2023 12:41
@ripienaar
Copy link
Contributor Author

Tested this one in a private repo, hopefully end of the noisy commits!

@ripienaar
Copy link
Contributor Author

Also tested that in raw logs secrets dont leaked when passed around this way

2023-03-15T12:50:49.0980771Z ##[group]Run docker login -u "***" -p "***"
2023-03-15T12:50:49.0981099Z �[36;1mdocker login -u "***" -p "***"�[0m

@ripienaar ripienaar merged commit 032b1f1 into nats-io:main Mar 15, 2023
@ripienaar ripienaar deleted the nightly_rc_docker.3 branch March 15, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ripienaar @neilalexander