-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Custom Muxer for websocket httpserver #4122
base: main
Are you sure you want to change the base?
Conversation
@jordan-rash thanks for the contribution! Could you retarget this into the |
=== RUN TestJetStreamLeafNodeClusterExtensionWithSystemAccount
=== RUN TestJetStreamLeafNodeClusterExtensionWithSystemAccount/true-true
=== RUN TestJetStreamLeafNodeClusterExtensionWithSystemAccount/true-false
=== RUN TestJetStreamLeafNodeClusterExtensionWithSystemAccount/false-true
=== RUN TestJetStreamLeafNodeClusterExtensionWithSystemAccount/false-false
--- PASS: TestJetStreamLeafNodeClusterExtensionWithSystemAccount (20.96s)
--- PASS: TestJetStreamLeafNodeClusterExtensionWithSystemAccount/true-true (2.25s)
--- PASS: TestJetStreamLeafNodeClusterExtensionWithSystemAccount/true-false (7.82s)
--- PASS: TestJetStreamLeafNodeClusterExtensionWithSystemAccount/false-true (3.08s)
--- PASS: TestJetStreamLeafNodeClusterExtensionWithSystemAccount/false-false (7.80s) Edit: looks like it was just a little hiccup in Travis! |
@wallyqs I will wait until this PR gets review and accepted/rejected before I squash all the commits. Thanks a ton team! |
ff03f2a
to
ed00549
Compare
Went ahead and rebased onto lastest |
@wallyqs is there any desire to get this rebased or should i just close?? |
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
Signed-off-by: jordan-rash <jordan-rash@users.noreply.github.com>
ed00549
to
943e9d0
Compare
Closes #3994
Resolves #3994
git pull --rebase origin main
)Changes proposed in this pull request
This PR adds the ability to provide the HTTP Server powering the Websocket with a custom muxer. The reason for this change is that it allows people to add a NATs powered websocket to an existing webapp without having multiple ports. Sample code below
Example usage
Custom Endpoint usage
nats-server on feat/websocket-mux via 🐹 v1.20.2 ❯ http localhost:8000 HTTP/1.1 200 OK Content-Length: 5 Content-Type: text/plain; charset=utf-8 Date: Tue, 02 May 2023 15:40:08 GMT hello
Websocket usage