Split JetStream cluster tests again #5332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to keep jetstream_cluster_3_test.go to just under 8 minutes and move the trail end to new jetstream_cluster_4_test.go. Notice that this file contains a test that itself takes more than 6 minutes to run. I checked without `-race` and it takes about as much. The test is: ``` TestJetStreamClusterStreamOrphanMsgsAndReplicasDrifting ``` I understand it does a lot of things, but wonder if it could be made a bit faster? @wallyqs I believe you have worked on that one? Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
|
@derekcollison I did what you asked, but the new "4" test file is already at 8+ minutes. This is because it contains the test aforementioned that takes 6+ minutes to run. If this test cannot be made way shorter, it is almost like it deserves its own matrix run, or in other words, we need already to start a "5" test file. |
|
@derekcollison Just to be clear, we leave as-is and @wallyqs will see if it can make the test shorter, or do I - part of this PR - make the file "4" contain only the long running test and add a file "5" with some of the tail tests that used to be in "3"? |
|
Leave as is for now.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to keep jetstream_cluster_3_test.go to just under 8 minutes and move the trail end to new jetstream_cluster_4_test.go.
Notice that this file contains a test that itself takes more than 6 minutes to run. I checked without
-raceand it takes about as much. The test is:I understand it does a lot of things, but wonder if it could be made a bit faster? @wallyqs I believe you have worked on that one?
Signed-off-by: Ivan Kozlovic ivan@synadia.com