When installing a new snapshot remove last inline if present. #5558
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were cleaning up all old ones and doing it in a go routine. However this could cause multiple go routines to race and delete the wrong snapshot leaving none available. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
raft-empty
branch
from
afb461d
to
3a56e5a
Compare
|
Had a small bug, but tracked it down. If green will merge after this run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (but not in released code) we were cleaning up all old ones in a go routine. However this could cause multiple go routines to race and delete the wrong snapshot leaving none available.
Signed-off-by: Derek Collison derek@nats.io