Cherry-picks for 2.10.17-RC.5 #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Chung <ken8203@gmail.com>
…r behavior. Signed-off-by: Derek Collison <derek@nats.io>
…h may already exist. (#5556) Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
Previously we were cleaning up all old ones and doing it in a go routine. However this could cause multiple go routines to race and delete the wrong snapshot leaving none available. Signed-off-by: Derek Collison <derek@nats.io>
|
@neilalexander yes I think Derek wanted to include it - let me see if I can change the test to not rely on that type |
|
@neilalexander added PR to fix test #5561 |
neilalexander
force-pushed
the
neil/21017rc5
branch
from
e3d4249
to
a526e6a
Compare
|
Excluded #5555 for now as will get the test sorted out for the next RC but we have NGS users blocked on the advisory streams. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
$JS.EVENT.>and$SYS.ACCOUNT.>which may already exist. #5556Signed-off-by: Neil Twigg neil@nats.io