Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] [CHANGE] current javascript clients close the connection on permission errors, this changes the behaviour to match other client implementations. Note that in some cases (like pub/req permissions) the only way to know that there was a permission error is via the status. On subscriptions, if callback, the
err
argument will provide the same.[FIX] on iterators, if a permission error triggered, the connection was closed, but the promise from the subscription backing it, remained pending.
Fixes #265