Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX 265 #267

Merged
merged 1 commit into from
Feb 20, 2022
Merged

FIX 265 #267

merged 1 commit into from
Feb 20, 2022

Commits on Feb 18, 2022

  1. [FIX] [CHANGE] current javascript clients close the connection on per… 

    …mission errors, this changes the behaviour to match other client implementations. Note that in some cases (like pub/req permissions) the only way to know that there was a permission error is via the status. On subscriptions, if callback, the `err` argument will provide the same.

[FIX] on iterators, if a permission error triggered, the connection was closed, but the promise from the subscription backing it, remained pending.

Fixes #265
    @aricart
    aricart committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d0a8af1 View commit details
    Browse the repository at this point in the history