Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript clients close the connection on permission error #265

Closed
aricart opened this issue Feb 18, 2022 · 0 comments · Fixed by #267
Closed

javascript clients close the connection on permission error #265

aricart opened this issue Feb 18, 2022 · 0 comments · Fixed by #267
Assignees

Comments

@aricart
Copy link
Member

aricart commented Feb 18, 2022

The JavaScript client since 2.0 deviates from standard practice of allowing clients to keep connected when pub/sub pub/sub permissions are raised.

aricart added a commit that referenced this issue Feb 18, 2022
…mission errors, this changes the behaviour to match other client implementations. Note that in some cases (like pub/req permissions) the only way to know that there was a permission error is via the status. On subscriptions, if callback, the `err` argument will provide the same.

[FIX] on iterators, if a permission error triggered, the connection was closed, but the promise from the subscription backing it, remained pending.

Fixes #265
@aricart aricart mentioned this issue Feb 18, 2022
aricart added a commit that referenced this issue Feb 20, 2022
…mission errors, this changes the behaviour to match other client implementations. Note that in some cases (like pub/req permissions) the only way to know that there was a permission error is via the status. On subscriptions, if callback, the `err` argument will provide the same. (#267)

[FIX] on iterators, if a permission error triggered, the connection was closed, but the promise from the subscription backing it, remained pending.

Fixes #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants