Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Subscriptions on unsub #32

Closed
mmmries opened this issue Mar 30, 2017 · 0 comments
Closed

Cleanup Subscriptions on unsub #32

mmmries opened this issue Mar 30, 2017 · 0 comments
Assignees

Comments

@mmmries
Copy link
Collaborator

mmmries commented Mar 30, 2017

When a client calls sub we record a mapping entry to map their sid to the receivers address (ie where we will deliver the messages). When a client calls unsub, we should remove this mapping. Also if a client calls unsub with max_messages: 1, we should automatically cleanup the mapping of sid => pid.

In the request/response flow we generate a new subscription for every request and failure to cleanup these subscriptions will result in a memory leak.

@mmmries mmmries changed the title Cleanup Subscriptions after max_messages Cleanup Subscriptions on unsub Mar 30, 2017
@mmmries mmmries self-assigned this Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant