-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base64
crate and use it in place of base64-url
#871
Conversation
34e6b30
to
a14d3d4
Compare
a14d3d4
to
36cfcbc
Compare
Sorry I pushed again as i forgot to run clippy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort.
This is more code rather than less, so am not inclined to merge as-is.
Might merge if you remove the base64 helper module, as most of those functions have helpers elsewhere (e.g encode_object_name is just calling encode with URL_SAFE config already.
0f5371b
to
b0e9ee2
Compare
Finally got the various different encodings right. I'll remove the base64.rs helper module next and squash everything |
7bbb4be
to
13a9671
Compare
This should now be ready to be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you @paolobarbolini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the
base64
crate to 0.21 and uses it everywhere for base64 url-safe encoding and decoding.Let me know if you like the small module I created to wrap the
base64
API with something easier to use or if you'd prefer callingbase64
directly