Cleanup dependencies #872
Merged
Cleanup dependencies #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
force-pushed
the
dependencies-cleanup
branch
from
7968269
to
372a31f
Compare
|
Thanks for the effort! For future PR's, I strongly suggest opening Issue first to discuss ideas to avoid work that might be rejected. |
The tokio `full` feature should never get enabled by a library as it forces downstream users to live with some useless features enabled, plus the extra dependencies.
tokio-retry was already part of the normal dependencies, so unless extra features needed to be enabled the import is useless.
once_cell is the correct way forward, as an API similar to it is also some day going to be stabilized in the Rust std. As some regexes were already using once_cell, this migrates the remaining ones.
paolobarbolini
force-pushed
the
dependencies-cleanup
branch
from
372a31f
to
4880f12
Compare
|
Rebased on top of main to hopefully get all jobs to pass |
caspervonb
reviewed
Mar 14, 2023
Jarema
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few dependency related issues.
This PR is best reviewed commit-by-commit.
Will create a merge conflict with #871