Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag commands which require a system account #134

Closed
philpennock opened this issue Apr 14, 2021 · 4 comments
Closed

Tag commands which require a system account #134

philpennock opened this issue Apr 14, 2021 · 4 comments

Comments

@philpennock
Copy link
Member

It would be very helpful if the commands available could minimally use a standard piece of syntax to mention those which require a system account as opposed to any account. I find myself repeatedly telling people "that error doesn't mean there's a problem, your account just doesn't have access".

Perhaps also if there were a way to decorate in the context with flags, we could mark those contexts (probably manually, or perhaps automatically after a connection test) which are system accounts, and then based on the current context we could elide showing the commands/completions which require a system account.

@ripienaar
Copy link
Collaborator

Any suggestions for how that would look, I've also wondered the same but can't think of a obvious yes not annoying way to do this. In general I tried to move all thigns that need system under nats server *

@philpennock
Copy link
Member Author

[system] at the end of the description?

@ripienaar
Copy link
Collaborator

Not convinced majority of people can be bothered to read help to spot that. Most run into this pasting stuff from docs etc.

I have started to improve errors though that feels like a more visible place to surface this that everyone will see?

fmt.Printf("%s status from $SYS.REQ.SERVER.PING, ensure a system account is used with appropriate permissions\n", msg.Header.Get("Status"))

@ripienaar
Copy link
Collaborator

made some progress on this, mostly good now, so will close this and will address more as they come up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants