Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Final notes #31

Closed
hettling opened this issue Nov 19, 2018 · 1 comment
Closed

Final notes #31

hettling opened this issue Nov 19, 2018 · 1 comment

Comments

@hettling
Copy link
Contributor

hettling commented Nov 19, 2018

  • [Done] In the en tibi vignette, the first paragraph is repeated.
  • [Done] Shark vignette: get_age is not a function. Should be geo_age?
  • [Done] Shark vignette: broken images?
  • [Done] Might be better to save the shark phylogeny as an R object (see save and use xz compression for CRAN ). That way the file can be compressed and loading is easier for a user: data(shark_phylogeney). See: http://r-pkgs.had.co.nz/data.html
  • [Done] It is good practice to spell out logicals: T and F should be TRUE and FALSE. (T and F are not protected)
  • [Done] Keep 80 column width in vignette examples please.
@hettling hettling added this to the Ropenscience-revision milestone Nov 19, 2018
hettling added a commit that referenced this issue Jan 28, 2019
@hettling
Copy link
Contributor Author

All points have been addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant