Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a new name for trans3d - clashes with grDevices #4

Closed
jefferis opened this issue Mar 30, 2014 · 5 comments
Closed

find a new name for trans3d - clashes with grDevices #4

jefferis opened this issue Mar 30, 2014 · 5 comments
Labels

Comments

@jefferis
Copy link
Contributor

grDevices is a base package so we can't mask that function

@jefferis jefferis added the bug label Mar 30, 2014
@jdmanton
Copy link
Contributor

Should I go back to the original idea of trans3d()?

@jdmanton
Copy link
Contributor

Temporarily fixed in bf86f3b by switching to trans() until a better name is invented.

@jefferis
Copy link
Contributor Author

I think we might need to look at a different architecture. To my mind your template brain objects are quite close to a reg argument, so if one was doing:

xform(neuron, reg=IS2)
xform(neuron, reg=c(IS2, FCWB))
# NB mirror currently has a warp not a reg argument, because of how we have separated
# the flipping and nonrigid components
mirror(neuron, reg=IS2)

that would make quite a bit of sense to me. One might then need a method like as.reg that converted them to a registration object. Right now we only have cmtkreg objects, but maybe it would be a good idea to have a more generic reg base class. But perhaps that is a separate issue – it would need a bit more effort since figuring out just what kind of reg object we had might require the same kind of registry approach implemented in fileformats. Since we are presently only using cmtk registrations for anything serious, we could just add a as.cmtkreg.TemplateBrain method.

@jdmanton
Copy link
Contributor

See also #6.

@jdmanton
Copy link
Contributor

Fixed in cd76438 by changing to xform_brain() and mirror_brain().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants