Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We lost IE8/9 support #77

Closed
naugtur opened this issue Jun 2, 2015 · 4 comments
Closed

We lost IE8/9 support #77

naugtur opened this issue Jun 2, 2015 · 4 comments

Comments

@naugtur
Copy link
Owner

naugtur commented Jun 2, 2015

I checked on virtual machines at work, and we lost support for old IEs
It seems that the only problem for now is that parse-headers is using .indexOf
Good news: noone reported that ;)

  1. We need to re-run tests in IEs more often. Who can help? Who has experience with browserstack free for opensource option?
  2. Change parse-headers or replace with something else?
  3. Integration tests are not IE compatible, I'll fix them by the end of the week (my bad)
@Raynos
Copy link
Collaborator

Raynos commented Jun 2, 2015

Hmm.

One of the reasons why there are no reports is that most people are still pinned to 1.x

We should fix the issue and look into saucelabs using Zuul.

Mercury and virtual Dom run ie tests there

@naugtur
Copy link
Owner Author

naugtur commented Jun 2, 2015

I'm spinning up a vm from MS to get back to debugging this thing.
parse-headers was in our dependencies in 1.x too as far as I remember. But I'm not sure if the problem with .indexOf wasn't a result of an incorrect response from the server or something.

I'll come back when I know something ;)

@naugtur
Copy link
Owner Author

naugtur commented Jun 2, 2015

Probably a false alarm.
After a lot of pain I can say that xhr seems to be working in IE8 just as expected (some cross-domain features not working for IE reasons)
It's our infrastructure that doesn't work in IEs anymore.

  1. run-browser adds a console replacement that uses some methods that aren't there
  2. tests were missing useXDR and tried to test features that are impossible in IE8

We won't func-test basic features in IEs without a localhost server. I'll see if it's possible to use paths that can be accessed with run-browser.

@naugtur
Copy link
Owner Author

naugtur commented Jul 10, 2015

Quite a delay, but I updated dev-dependencies and fixed tests adf63ad

Opening a new issue for Zuul #81

@naugtur naugtur closed this as completed Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants