Handle error events correctly #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `onerror` and `ontimeout` handler are not calling back with errors but with error events (without any messages). Therefore the `errorFunc` is wrapping them as `Error: [ProgressEvent object]`. Here's my quick proposal on how to fix this. Just pass generic error messages to the `errorFunc`, then there will be no case where the error needs to be constructed there.
|
It's not a surprise. The check for error type was there for the case when the function is called with an error. The split between error and timeout could be useful though. It's a breaking change, so I'll schedule merging this for 3.0 |
|
+1 for a fix for this. |
|
Closing this one in favor of #164 - the same thing but rebased on top of current development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onerrorandontimeouthandler are not calling back with errors but with error events (without any messages). Therefore theerrorFuncis wrapping them asError: [ProgressEvent object].Here's my quick proposal on how to fix this. Just pass generic error messages to the
errorFunc, then there will be no case where the error needs to be constructed there.The spec can be quite helpful here: https://xhr.spec.whatwg.org/