Finnp patch 1 - Handle error events correctly #164
Conversation
The `onerror` and `ontimeout` handler are not calling back with errors but with error events (without any messages). Therefore the `errorFunc` is wrapping them as `Error: [ProgressEvent object]`. Here's my quick proposal on how to fix this. Just pass generic error messages to the `errorFunc`, then there will be no case where the error needs to be constructed there.
|
@finnp Could you review what I changed on top of your PR and let me know if you have any concerns? |
|
@naugtur Hey, we're affected by a similar problem with unhandled error on a project, so wondering when do you plan to ship changes into For the time being, we forked the repo and did local changes, so we can reference |
|
I was going to release a new major version for quite a while now, but ran out of time and contributors. If you could help, it becomes more likely. |
|
@naugtur What kind of help do you expect? Tell me how I can help and I'll try to allocate time. |
|
@nicksp I don't have any expectations. I'm just a humble developer that happens to be involved in this project :) If you want to help, the absolute first step is this: It'd allow improvements to tests and make it more certain that changes don't break anything. With With 2 people involved I was hoping to get the v3 done and published in 2017, but we didn't end up getting to it. |
@finnp I rebased your PR onto current v3 work
I'm making minor changes and I want this to have tests too.
You should find an invite to be a collaborator in your email, which lets you work on this branch directly.