Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Consolidating Assigned Devices and Assigned dynamic groups #65

Open
itdependsnetworks opened this issue Jul 10, 2022 · 2 comments
Labels
roadmap: near term status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement

Comments

@itdependsnetworks
Copy link
Contributor

Environment

  • Nautobot version: 1.3
  • nautobot-plugin-firewall-model version: 0.1

Proposed Functionality

There are currently both Assigned Devices and Assigned dynamic groups, I am proposing to consolidate down to just dynamic groups. This will continue to be used in the Nautobot ecosystem, with more reliance and knowledge of it moving forward.

Use Case

There is complication in that both have weight. Let's explore an issue.

  • A Policy Deny-Bogons is assigned to device=nyc-fw01 with weight 100 and dynamic_group={site: nyc} with weight 1000
  • Another Policy Allow-Internet is applied to the device with weight 500
  • What should the order of policy be?

Conceptually, this will not work, and while I understand that we can simply document "operator beware", not to do such a thing, it is still odd.

As a developer of a job or creating configuration management from the system, it is not clear what the intention should be, for either prefer assigned devices or dynamic groups

As a developer, there is an increased complication to always determine given a set of Policies, which Device's are actually in scope.

As a developer, there is an increased complication to always determine given a set of Devices, which Policy's are actually in scope.

As an alternate, I believe that the assigned devices and dynamic groups should at a minimum be mutually exclusive, but would prefer to aggregate down to dynamic groups.

@itdependsnetworks
Copy link
Contributor Author

In speaking with @whitej6 go with "As an alternate, I believe that the assigned devices and dynamic groups should at a minimum be mutually exclusive, but would prefer to aggregate down to dynamic groups."

@whitej6
Copy link
Contributor

whitej6 commented Jul 17, 2022

Accepted as validation to pre-vent assigning both attrs AND creating a connivence method to return a device queryset via #70 to return relevant devices to a policy.

@whitej6 whitej6 added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement roadmap: near term labels Jul 17, 2022
@whitej6 whitej6 mentioned this issue Jul 18, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap: near term status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants