Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: should we support deleting PRs? #48

Closed
jedelman8 opened this issue Aug 31, 2021 · 3 comments · Fixed by #82 or #99
Closed

question: should we support deleting PRs? #48

jedelman8 opened this issue Aug 31, 2021 · 3 comments · Fixed by #82 or #99
Assignees
@VinaiRachakonda
Milestone
1.0.0

Comments

@jedelman8
Copy link
Contributor

No description provided.

@jedelman8 jedelman8 added this to the 1.0.0 milestone Aug 31, 2021
@jedelman8 jedelman8 mentioned this issue Aug 31, 2021
Closed
@jedelman8 jedelman8 added the status: internal review Internal discussion is required to move forward with issue label Aug 31, 2021
@VinaiRachakonda VinaiRachakonda linked a pull request Sep 14, 2021 that will close this issue
add changes for blocking delete on branches with prs #82
Merged
@VinaiRachakonda
Copy link
Contributor

image

@VinaiRachakonda
Copy link
Contributor

Block branch deletes when un deleted pr exists

@VinaiRachakonda VinaiRachakonda self-assigned this Sep 14, 2021
@VinaiRachakonda VinaiRachakonda linked a pull request Sep 20, 2021 that will close this issue
Address global state and test cases #99
Merged
@VinaiRachakonda
Copy link
Contributor

Seemed to be a problem with how global state was being written

@jedelman8 jedelman8 removed the status: internal review Internal discussion is required to move forward with issue label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinaiRachakonda VinaiRachakonda

Labels
None yet
Projects
None yet
Milestone
1.0.0
3 participants
@jedelman8 @VinaiRachakonda @andy-wm-arthur