Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Allow API Key to be specified in config or read from file #22

Closed
nniehoff opened this issue Jul 8, 2022 · 1 comment · Fixed by #25
Closed

Allow API Key to be specified in config or read from file #22

nniehoff opened this issue Jul 8, 2022 · 1 comment · Fixed by #25

Comments

@nniehoff
Copy link

nniehoff commented Jul 8, 2022

When deploying this plugin in our environment I store the API key in hashicorp vault. I can query vault in the Nautobot config file very easily. I can also use the vault agent to inject the secret as a file but injecting it as an environment variable is much harder with vault and arguably less secure. I would suggest allowing this variable to be set in the config file where I can configure any way I might want.

@ubajze
Copy link
Contributor

ubajze commented Jul 11, 2022

Looks like you can pass the API key as a variable.
https://github.com/meraki/dashboard-api-python/blob/371047b7d362a2b7023447c5e261501bb0b29cad/meraki/__init__.py#L78

It would be great if we can read the API key from Nautobot settings instead of rely on the env variable only.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants