-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Config Context with Dynamic Groups #3182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Can you update these tests in
This would probably be a good candidate for a new test to ensure the filtering is working properly:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to add some tests and update the filter name and should be good to go
Co-authored-by: Jathan McCollum <jathan@gmail.com>
Co-authored-by: Jathan McCollum <jathan@gmail.com>
Co-authored-by: Jathan McCollum <jathan@gmail.com>
Co-authored-by: Jathan McCollum <jathan@gmail.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to put a hold on this for the moment - see my comment about the API. Hopefully we'll have an answer to that point shortly!
nautobot/extras/migrations/0056_alter_configcontext_dynamic_groups.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the migrations into one if possible
Change requested (squash migrations) addressed.
see #3432. |
Closes: #3271
What's Changed
Add functionality to apply config context items based on dynamic groups. This new feature is feature flagged with the
CONFIG_CONTEXT_DYNAMIC_GROUPS_ENABLED
innautobot.core.settings
.TODO