(Upgrades for /depends + gitian-*.yml setup)(Fix for Coin Control "sorting" bug) (Fix for windows builds hashes) (Statically linked libcurl) #461

mxaddict · 2019-05-02T12:39:45Z

Fix for Coin Control "sorting" bug

This is a fix for issues #427 #471 #473

mxaddict · 2019-05-02T13:02:19Z

NOTE: The fix involves upgrading to QT 5.9.8, which breaks compatibility for OSX older than 10.10

For normal users, --no-same-owner is default, but not so for root, where it is assumed that root can change ownership willy-nilly. This is not the case for privilege-limited container environments where we gaslight the process into thinking it's root.

…untu Failed, Debian Working)

…with /depends libexpat

…n mac

…-core

…oin Cointrol dialog

aguycalled · 2019-05-15T19:22:06Z

Hashes of my builds:

529345176af82959a39aa1ccd93589edb1843025c17d00e961c9c1f01a6ba26e  navcoin-4.6.0-arm-linux-gnueabihf.tar.gz
a9371072b2a1931e191a8d26505b4e95e20e2b0d3984ed633b70e891346b435b  navcoin-4.6.0-i686-pc-linux-gnu.tar.gz
d8bf8c19fd3bd15f7040c6ac018d39ea8cf05567d5b4f3ef4bbe8bfd7fdc5108  navcoin-4.6.0-osx-unsigned.dmg
d89ad4c4016834ed7ccd43cfb3a51713d5a8eab8c7f563bda3ab7593d109dd53  navcoin-4.6.0-osx-unsigned.tar.gz
6404cc63c8d9b4c9f3b67c04f3ad68a590518fb28b1db50933a78c298c322d4d  navcoin-4.6.0-osx64.tar.gz
4bf7b84019a6a5b7bb0e08c1df76ce37101850ad62dac18ab8505785fdd93900  navcoin-4.6.0-win32-setup-unsigned.exe
2bfeaca0a9a1a9beca2fa5dff09f551b28b9d80caae5fb2fb4edd0e1bfa3ce30  navcoin-4.6.0-win32.zip
e112692aa62e48180d738ccd80a2c00b9d87afd3d445c1d2f08f0e14c35b7f5a  navcoin-4.6.0-win64-setup-unsigned.exe
a1bc0ab3cfba76bc2e3f9016b8d02fd46a9073b6a0a8d788cde2f8def6bbbc3b  navcoin-4.6.0-win64.zip
178ec34849ed4349ee998a7d0a0d2b321d2a215c0b17a0a67b164bb7dfe34f7b  navcoin-4.6.0-x86_64-linux-gnu.tar.gz
5e44a45c8791355ae3b79e0b1a40d0655908f051d52a74a98ed5527f986cc27a  navcoin-4.6.0.tar.gz

Everything matches except osx

mxaddict · 2019-05-15T19:24:05Z

Hashes of my builds:

a2f931814d31c392d978f8b145d0e7c10a04fff826a8ee0528bb252a64c7fcbf navcoin-4.6.0-aarch64-linux-gnu.tar.gz 529345176af82959a39aa1ccd93589edb1843025c17d00e961c9c1f01a6ba26e navcoin-4.6.0-arm-linux-gnueabihf.tar.gz a9371072b2a1931e191a8d26505b4e95e20e2b0d3984ed633b70e891346b435b navcoin-4.6.0-i686-pc-linux-gnu.tar.gz d8bf8c19fd3bd15f7040c6ac018d39ea8cf05567d5b4f3ef4bbe8bfd7fdc5108 navcoin-4.6.0-osx-unsigned.dmg d89ad4c4016834ed7ccd43cfb3a51713d5a8eab8c7f563bda3ab7593d109dd53 navcoin-4.6.0-osx-unsigned.tar.gz 6404cc63c8d9b4c9f3b67c04f3ad68a590518fb28b1db50933a78c298c322d4d navcoin-4.6.0-osx64.tar.gz 4bf7b84019a6a5b7bb0e08c1df76ce37101850ad62dac18ab8505785fdd93900 navcoin-4.6.0-win32-setup-unsigned.exe 2bfeaca0a9a1a9beca2fa5dff09f551b28b9d80caae5fb2fb4edd0e1bfa3ce30 navcoin-4.6.0-win32.zip e112692aa62e48180d738ccd80a2c00b9d87afd3d445c1d2f08f0e14c35b7f5a navcoin-4.6.0-win64-setup-unsigned.exe a1bc0ab3cfba76bc2e3f9016b8d02fd46a9073b6a0a8d788cde2f8def6bbbc3b navcoin-4.6.0-win64.zip 178ec34849ed4349ee998a7d0a0d2b321d2a215c0b17a0a67b164bb7dfe34f7b navcoin-4.6.0-x86_64-linux-gnu.tar.gz 5e44a45c8791355ae3b79e0b1a40d0655908f051d52a74a98ed5527f986cc27a navcoin-4.6.0.tar.gz

Everything matches but osx

Hmmm, what SDK did you use for the OSX build?

mxaddict · 2019-05-15T19:24:43Z

This is the SDK that I used:

curl --location --fail https://bitcoincore.org/depends-sources/sdks/MacOSX10.11.sdk.tar.gz -o inputs/MacOSX10.11.sdk.tar.gz

aguycalled · 2019-05-15T19:24:46Z

bc1cf275e3cc675e820aecb72f98f587257d59fcf27f8dfafd4a176430594be9  MacOSX10.11.sdk.tar.gz

mxaddict · 2019-05-15T19:25:35Z

bec9d089ebf2e2dd59b1a811a38ec78ebd5da18cbbcd6ab39d1e59f64ac5033f  ../gitian-builder/inputs/MacOSX10.11.sdk.tar.gz

aguycalled · 2019-05-15T19:26:03Z

will get it from bitcoincore and relaunch mac build

mxaddict · 2019-05-15T19:27:15Z

will get it from bitcoincore and relaunch mac build

ACK

aguycalled · 2019-05-15T19:47:18Z

a55c619308766030a846a37c116d96886d674da84cc790f4a5ac9b8110499bac  navcoin-4.6.0-osx-unsigned.dmg
ca1a50867b15e0e71b483f3402dbfe447e0f3b91c8f79790a58b3280c75e2021  navcoin-4.6.0-osx-unsigned.tar.gz
033c8e83159f6eaf638b59be3e8b1b4fc792fbf0b5f0cb8bab00a2c5a634f1ac  navcoin-4.6.0-osx64.tar.gz

bingo

aguycalled · 2019-05-15T19:50:59Z

tested correctly executed in enviroment without libcurl

aguycalled · 2019-05-15T19:57:35Z

tested locally in debian

aguycalled · 2019-05-02T17:54:48Z

configure.ac

-    # All windows code is PIC, forcing it on just adds useless compile warnings
-    AX_CHECK_COMPILE_FLAG([-fPIC],[PIC_FLAGS="-fPIC"])
-   fi
-


why is this removed?

May have been an oversight on my part when merging upstream changes.

I'll re-add it.

i remember seeing this alert when building the gui in some systems, but maybe it's not necessary anymore with the new qt version

NVM, it was not removed, it was MOVED :D

This was removed:

AX_CHECK_COMPILE_FLAG([-fPIC],[CFLAGS="-fPIC"])

And

AX_CHECK_COMPILE_FLAG([-fPIC],[PIC_FLAGS="-fPIC"])

Was put in it's place.

mxaddict · 2019-05-15T20:19:48Z

tested correctly executed in enviroment without libcurl

Were you able to also test the original issue for this PR?

Sorting of the inputs on coin control dialog 👍

aguycalled · 2019-05-15T20:46:46Z

yes, the issue is fixed for me

proletesseract · 2019-05-22T21:45:49Z

compiling on linux now. do you want me to run a full gititan build and compare hashes?

mxaddict · 2019-05-22T21:46:46Z

compiling on linux now. do you want me to run a full gititan build and compare hashes?

Yes please, that is one of the fixes, all build hashes should match 👍

proletesseract · 2019-05-24T05:12:57Z

my linux build finished and the hashes match

proletesseract · 2019-05-27T05:12:47Z

Linux hashes

600fffa7e6072b4062c404ba54aa68ba002717ee5dce26bbbca95e6428281439  build/out/navcoin-4.6.0-aarch64-linux-gnu-debug.tar.gz
a2f931814d31c392d978f8b145d0e7c10a04fff826a8ee0528bb252a64c7fcbf  build/out/navcoin-4.6.0-aarch64-linux-gnu.tar.gz
25a7dc2fea99fc8b605a2cc694d73bda367589c6436c2542956ac9e423460b5c  build/out/navcoin-4.6.0-arm-linux-gnueabihf-debug.tar.gz
529345176af82959a39aa1ccd93589edb1843025c17d00e961c9c1f01a6ba26e  build/out/navcoin-4.6.0-arm-linux-gnueabihf.tar.gz
778e92dd93cf725178a50c42be2be290ea83a2f14f44b69d791528c9e2c1a4c0  build/out/navcoin-4.6.0-i686-pc-linux-gnu-debug.tar.gz
a9371072b2a1931e191a8d26505b4e95e20e2b0d3984ed633b70e891346b435b  build/out/navcoin-4.6.0-i686-pc-linux-gnu.tar.gz
ee9581e9fbae17a2c876816a3494df67e530ed59b8c948a51df08de281ee0ede  build/out/navcoin-4.6.0-x86_64-linux-gnu-debug.tar.gz
178ec34849ed4349ee998a7d0a0d2b321d2a215c0b17a0a67b164bb7dfe34f7b  build/out/navcoin-4.6.0-x86_64-linux-gnu.tar.gz

OSX hashes

a55c619308766030a846a37c116d96886d674da84cc790f4a5ac9b8110499bac  build/out/navcoin-4.6.0-osx-unsigned.dmg
ca1a50867b15e0e71b483f3402dbfe447e0f3b91c8f79790a58b3280c75e2021  build/out/navcoin-4.6.0-osx-unsigned.tar.gz
033c8e83159f6eaf638b59be3e8b1b4fc792fbf0b5f0cb8bab00a2c5a634f1ac  build/out/navcoin-4.6.0-osx64.tar.gz

Windows hashes

b1dd88cdd8bf09af2539d0b345e647129d8fd55c92b6d824b6ecc53efd531028  build/out/navcoin-4.6.0-win.tar.gz
11f3e4170f104c2ffc78e08603a03df7a9be22fe72431932e4063d42412d230b  build/out/navcoin-4.6.0-win32-debug.zip
4bf7b84019a6a5b7bb0e08c1df76ce37101850ad62dac18ab8505785fdd93900  build/out/navcoin-4.6.0-win32-setup-unsigned.exe
2bfeaca0a9a1a9beca2fa5dff09f551b28b9d80caae5fb2fb4edd0e1bfa3ce30  build/out/navcoin-4.6.0-win32.zip
df559db6d69bb4b01a69bd8dd981bbac947dee781087e0f567772feb8f54227f  build/out/navcoin-4.6.0-win64-debug.zip
e112692aa62e48180d738ccd80a2c00b9d87afd3d445c1d2f08f0e14c35b7f5a  build/out/navcoin-4.6.0-win64-setup-unsigned.exe
a1bc0ab3cfba76bc2e3f9016b8d02fd46a9073b6a0a8d788cde2f8def6bbbc3b  build/out/navcoin-4.6.0-win64.zip

All matching

mxaddict added 2 commits May 2, 2019 16:14

Updated the QT version used in depends to version 5.9.8

dc7d697

Updated fontconfig version

6f40170

mxaddict requested review from proletesseract and aguycalled May 2, 2019 13:23

mxaddict added 11 commits May 3, 2019 01:21

Removed < qt 5.5.1 support

b5dcf4b

Missed a legacy file for qt4 support

40401d9

Added one too many --no-same-owner

be0305f

Updated more code in /depends from upstream bitcoin code

6c45908

Merge branch 'patch-6' into patch-5

c60c95b

Uncommented the test includes

a538d4e

Removed some QT plugins that were not in use

1de79ff

More upstream changes from bitcoin-core

97fdda7

Fixed the compile issues on Certain combinations of the toolchain (Ub…

96e7778

…untu Failed, Debian Working)

Updated libexpat and unbound versions then forced unbound to compile …

922c486

…with /depends libexpat

mxaddict force-pushed the patch-5 branch from fe51f40 to 922c486 Compare May 4, 2019 04:24

mxaddict added 5 commits May 4, 2019 13:39

Updated the HOST value to darwin14 from darwin11 for travisci build o…

aaf1003

…n mac

Updated bdb.mk based on bitcoin-core upstream changes

33b205b

Updated native_cctools based on upstream changes from bitcoin-core

1e98cce

Updated mode /depends/packages based on upstream changes from bitcoin…

89f74f0

…-core

Updated more /depends/packages based on upstream changes from bitcoin…

f35ec23

…-core

mxaddict force-pushed the patch-5 branch 2 times, most recently from 406eb1c to a7b7e63 Compare May 4, 2019 07:32

Updated removed cache from depends and use system cache

5885a3c

mxaddict force-pushed the patch-5 branch from a7b7e63 to 5885a3c Compare May 4, 2019 07:40

mxaddict added 4 commits May 4, 2019 16:06

Updated minimum OSX version to 10.10

eda56ff

Fixe OSX build on travis

39ca25c

Fixed sorting bug for confirmations, priority and amount columns in C…

14d4f92

…oin Cointrol dialog

Merge remote-tracking branch 'fork/master' into patch-5

2569a6a

mxaddict mentioned this pull request May 15, 2019

PR #461 requires GLIBC 2.27 on x86_64 and i686 linux build #482

Closed

aguycalled approved these changes May 15, 2019

View reviewed changes

mxaddict requested a review from matt-auckland May 15, 2019 20:05

aguycalled added bounty pending payment ready for review labels May 15, 2019

aguycalled approved these changes May 21, 2019

View reviewed changes

proletesseract approved these changes May 27, 2019

View reviewed changes

proletesseract merged commit a4c8eb6 into navcoin:master May 27, 2019

aguycalled added bounty paid and removed bounty pending payment labels May 27, 2019

mxaddict mentioned this pull request May 30, 2019

Changes required for GLIBC backward compatibility with gitian builds #501

Merged

This was referenced Jun 10, 2019

Updated images to try and fix #521 #522

Closed

OSX gitian build of master branch is funky looking #521

Closed

mxaddict mentioned this pull request Jul 1, 2019

v4.7.0 rc #545

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(Upgrades for /depends + gitian-*.yml setup)(Fix for Coin Control "sorting" bug) (Fix for windows builds hashes) (Statically linked libcurl) #461

(Upgrades for /depends + gitian-*.yml setup)(Fix for Coin Control "sorting" bug) (Fix for windows builds hashes) (Statically linked libcurl) #461

mxaddict commented May 2, 2019 •

edited

Loading

mxaddict commented May 2, 2019

aguycalled commented May 15, 2019 •

edited

Loading

mxaddict commented May 15, 2019

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019 •

edited

Loading

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019 •

edited

Loading

aguycalled commented May 15, 2019

aguycalled commented May 15, 2019

aguycalled May 2, 2019

mxaddict May 15, 2019

aguycalled May 15, 2019

mxaddict May 15, 2019

mxaddict May 15, 2019

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019

proletesseract commented May 22, 2019

mxaddict commented May 22, 2019

proletesseract commented May 24, 2019

proletesseract commented May 27, 2019

(Upgrades for /depends + gitian-*.yml setup)(Fix for Coin Control "sorting" bug) (Fix for windows builds hashes) (Statically linked libcurl) #461

(Upgrades for /depends + gitian-*.yml setup)(Fix for Coin Control "sorting" bug) (Fix for windows builds hashes) (Statically linked libcurl) #461

Conversation

mxaddict commented May 2, 2019 • edited Loading

mxaddict commented May 2, 2019

aguycalled commented May 15, 2019 • edited Loading

mxaddict commented May 15, 2019

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019 • edited Loading

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019 • edited Loading

aguycalled commented May 15, 2019

aguycalled commented May 15, 2019

aguycalled May 2, 2019

Choose a reason for hiding this comment

mxaddict May 15, 2019

Choose a reason for hiding this comment

aguycalled May 15, 2019

Choose a reason for hiding this comment

mxaddict May 15, 2019

Choose a reason for hiding this comment

mxaddict May 15, 2019

Choose a reason for hiding this comment

mxaddict commented May 15, 2019

aguycalled commented May 15, 2019

proletesseract commented May 22, 2019

mxaddict commented May 22, 2019

proletesseract commented May 24, 2019

proletesseract commented May 27, 2019

mxaddict commented May 2, 2019 •

edited

Loading

aguycalled commented May 15, 2019 •

edited

Loading

aguycalled commented May 15, 2019 •

edited

Loading

aguycalled commented May 15, 2019 •

edited

Loading