Skip to content

Replaced all BOOST_FOREACH calls with new for() syntax (c++11) - #525

Merged
mxaddict merged 2 commits into
navcoin:masterfrom
mxaddict:patch-27
Oct 16, 2019
Merged

Replaced all BOOST_FOREACH calls with new for() syntax (c++11)#525
mxaddict merged 2 commits into
navcoin:masterfrom
mxaddict:patch-27

Conversation

@mxaddict

@mxaddict mxaddict commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

aguycalled
aguycalled approved these changes Jun 12, 2019
View reviewed changes

@aguycalled aguycalled left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed changes, pending travis

@aguycalled

aguycalled commented Jun 13, 2019

Copy link
Copy Markdown
Member

should we add a linter to check there's no regression on this?

@mxaddict

mxaddict commented Jun 13, 2019

Copy link
Copy Markdown
Contributor Author

should we add a linter to check there's no regression on this?

Make sense, but I think we need to finish the functional-tests branch changes before adding the linter?

@proletesseract

proletesseract commented Jun 16, 2019

Copy link
Copy Markdown
Member

Resolved merge conflict after merging PR #524, waiting on travis.

builds and runs on ubuntu 18.04

@mxaddict

mxaddict commented Jun 17, 2019

Copy link
Copy Markdown
Contributor Author

Rebasing now, will push when done.

@mxaddict

mxaddict commented Jun 17, 2019

Copy link
Copy Markdown
Contributor Author

Rebasing now, will push when done.

Rebase pushed

@mxaddict mxaddict mentioned this pull request Jul 17, 2019
Open
@mxaddict

mxaddict commented Sep 25, 2019

Copy link
Copy Markdown
Contributor Author

Merged changes from master

@mxaddict

mxaddict commented Oct 9, 2019

Copy link
Copy Markdown
Contributor Author

Rebased PR on updated master branch.

chasingkirkjufell
chasingkirkjufell approved these changes Oct 15, 2019
View reviewed changes

@chasingkirkjufell chasingkirkjufell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested sending, receiving, creating proposals, creating payment requests, staking, syncing on mainnet, on ubuntu 18.10

@mxaddict

mxaddict commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

Fixed merge conflict, will merge when builds for the daemon and QT on windows/osx pass

@mxaddict
mxaddict merged commit 2e6aa1b into navcoin:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aguycalled aguycalled aguycalled approved these changes
@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes
@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees

No one assigned

Labels

ready for review refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mxaddict @aguycalled @proletesseract @chasingkirkjufell