Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced all BOOST_FOREACH calls with new for() syntax (c++11) #525

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Replaced all BOOST_FOREACH calls with new for() syntax (c++11) #525

merged 2 commits into from
Oct 16, 2019

Conversation

mxaddict
Copy link
Contributor

No description provided.

aguycalled
aguycalled approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed changes, pending travis

@aguycalled
Copy link
Member

should we add a linter to check there's no regression on this?

@mxaddict
Copy link
Contributor Author

should we add a linter to check there's no regression on this?

Make sense, but I think we need to finish the functional-tests branch changes before adding the linter?

@proletesseract
Copy link
Member

Resolved merge conflict after merging PR #524, waiting on travis.

builds and runs on ubuntu 18.04

@mxaddict
Copy link
Contributor Author

Rebasing now, will push when done.

@mxaddict
Copy link
Contributor Author

Rebasing now, will push when done.

Rebase pushed

@mxaddict mxaddict mentioned this pull request Jul 17, 2019
Open
@mxaddict
Copy link
Contributor Author

Merged changes from master

@mxaddict
Copy link
Contributor Author

mxaddict commented Oct 9, 2019

Rebased PR on updated master branch.

chasingkirkjufell
chasingkirkjufell approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested sending, receiving, creating proposals, creating payment requests, staking, syncing on mainnet, on ubuntu 18.10

@mxaddict
Copy link
Contributor Author

Fixed merge conflict, will merge when builds for the daemon and QT on windows/osx pass

@mxaddict mxaddict merged commit 2e6aa1b into navcoin:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguycalled aguycalled aguycalled approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees
No one assigned
Labels
ready for review refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxaddict @aguycalled @proletesseract @chasingkirkjufell