Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layout for different device screens #15

Closed
aguycalled opened this issue Mar 16, 2022 · 4 comments · Fixed by #82
Closed

Fix Layout for different device screens #15

aguycalled opened this issue Mar 16, 2022 · 4 comments · Fixed by #82
Assignees

Comments

@aguycalled
Copy link
Member

For example, Onboarding screen looks broken on iPad.

@tsejerome
Copy link
Contributor

We shd set our layout to dynamically adjust. There are some react native packages for handling that, will do that later on.

Overall, we shd have a list of preferred devices for testing too, with rationale as mentioned at #15. Especially when we handle issues like #17 and #15

@tsejerome
Copy link
Contributor

Screens iPhone 8 iPhone 12 Pro Max iPad Air iPad Pro Pixel 2 Pixel 5
AddressScreen
AddServerScreen
HistoryScreen
MainWalletScreen
MenmonicScreen
SendToScreen
AddServerScreenViewTXScreen
OnboardingScreen

@aguycalled Thoughts on this flow? Any screens I'm missing?

@aguycalled
Copy link
Member Author

I think AddServerScreenViewTXScreen has a typo and refers to two different screens.

I would also add the Screens under navigation/: CreateNewWallet, ImportWallet and OpenWallet.

@tsejerome
Copy link
Contributor

tsejerome commented Apr 7, 2022

Thanks for the notes, will test on these:

Screens iPhone 8 iPhone 12 Pro Max iPad Air iPad Pro Pixel 2 Pixel 5
Non Wallet Screens --- --- --- --- --- ---
Intro Screen
OnboardingScreen
CreateNewWallet
ImportWallet
OpenWallet
Wallet Screens --- --- --- --- --- ---
AddressScreen
AddServerScreen
SettingScreen
HistoryScreen
MainWalletScreen
MenmonicScreen
SendToScreen
AddServerScreen
ViewTXScreen

Note that we should only allow "Portrait" as Device Orientation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants