Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: TypeError: Right-hand side of 'instanceof' is not an object when use jQuery.noConfilct(true) #223

Closed
belozer opened this issue Oct 1, 2018 · 3 comments
Assignees
Labels

Comments

@belozer
Copy link

belozer commented Oct 1, 2018

Description

TypeError: Right-hand side of 'instanceof' is not an object when use jQuery.noConfilct(true)

Steps to check or reproduce

  1. add jquery and run window.jQuery.noConfilct(true)
  2. Set container
const ig = new InfiniteGrid(myHTMLElementContainer);
ig.setLayout(InfiniteGrid.GridLayout, { align : 'justify' });
ig.layout();

Problem in this string

} else if (("jQuery" in window && param instanceof window.jQuery) ||

@belozer belozer changed the title bug bug: TypeError: Right-hand side of 'instanceof' is not an object when use jQuery.noConfilct(true) Oct 1, 2018
@belozer
Copy link
Author

belozer commented Oct 1, 2018

Maybe better use typeof?
} else if (typeof window.jQuery !== 'undefined' && param instanceof window.jQuery) ||
or
} else if (window.jQuery && param instanceof window.jQuery) ||

@jongmoon
Copy link

jongmoon commented Oct 2, 2018

@belozer Thank you for reporting. 👍

@daybrush
Copy link
Member

daybrush commented Oct 4, 2018

@belozer

Thank you for reporting. It has been fixed. @egjs/infinitegrid 3.4.4 version has been deployed

@daybrush daybrush closed this as completed Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants