Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing unnecessary warning message when run persist method as getter #199

Closed
happyhj opened this issue May 4, 2016 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@happyhj
Copy link
Contributor

happyhj commented May 4, 2016

Description

When storage has no item for persist, it's own getItem method will return null object.
This make persist mudule showing unnecessary warning message.

Steps to check or reproduce

  1. import jquery & egjs master
  2. execute persist method as getter.
    $.persist("KEY") or $.persist()

it will show warning message on console

@happyhj happyhj self-assigned this May 4, 2016
@happyhj happyhj added the persist label May 4, 2016
@happyhj happyhj added this to the 1.2.0 milestone May 4, 2016
happyhj added a commit to happyhj/egjs that referenced this issue May 4, 2016
fixed test for using wrong key on storage

ref naver#199
happyhj added a commit to happyhj/egjs that referenced this issue May 10, 2016
fixed test for using wrong key on storage

ref naver#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant