fix(persist): don't show warning message on clean storage #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed test for using wrong key on storage ref naver#199
happyhj
changed the title
|
I think that it have to divide isssue.(prehook/presist) and I prefer to merge persist issues. |
| @@ -89,6 +89,13 @@ eg.module("persist", ["jQuery", eg, window, document], function($, ns, global, d | |||
| var stateStr = storage ? | |||
| storage.getItem(location.href + CONST_PERSIST) : history.state; | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
Why did you insert these commented code?
|
I got it your intend by offline chat! Thank you! LGTM |
|
I'll make separated two PR by issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#197
#199
Details
chore(all): Remove unit testing task from prepush hook
fix(persist): don't show warning message on clean storage
Preferred reviewers
@naver/egjs-committers @sculove @jongmoon