This repository has been archived by the owner on May 5, 2023. It is now read-only.
Cu-237y7h0 contract updates to collateral settings #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-237y7h0 Contract Updates to Collateral Settings |
* fix ACL context init * fix role checks * fix event emission * fix insured party address resolution when paying claims
- git ignore .jshintrc - premium amount must be > 0 - remove conflicting event (PolicyStateUpdated) use only SimplePolicyStateUpdated for simple policies instead
- fix requirements for max capital and collateral ratio - clean up logging statements - add test stubs for heartbeat
amarinkovic
force-pushed
the
CU-237y7h0_contract_updates_to_collateral_settings
branch
from
2a34dc3
to
cda42ff
Compare
* remove reentrancy guard * remove unit and limit getters * set treasury ref on simple policy
amarinkovic
force-pushed
the
CU-237y7h0_contract_updates_to_collateral_settings
branch
from
e5e09ab
to
c6e2453
Compare
amarinkovic
force-pushed
the
CU-237y7h0_contract_updates_to_collateral_settings
branch
from
8bd2a6d
to
9c2ad34
Compare
- test heart beat function - test claims payout preconditions - test premium payout preconditions
- test policy limit is below max capital - expose total limit for currency - test total limit deduction on policy maturation - remove commented out code
- test allow simple policy - test claims and premiums paid amounts after payout
amarinkovic
changed the title
amarinkovic
deleted the
CU-237y7h0_contract_updates_to_collateral_settings
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.