Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chanfeed: use get_all_threads instead of get_threads or loop pages #7

Open
nazunalika opened this issue May 2, 2020 · 0 comments
Open
Labels
enhancement New feature or request under review

Comments

@nazunalika
Copy link
Owner

nazunalika commented May 2, 2020

If a thread is being added that is not on page 1, there is a possibility it may be missed and an exception for the thread not existing will appear. We have not ran into this, but we are opening this just in case it does happen.

We need to determine if we can use get_all_threads or loop all pages for get_threads if the exception ever occurs.

@nazunalika nazunalika added enhancement New feature or request under review labels May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under review
Projects
None yet
Development

No branches or pull requests

1 participant