Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST's deletion is buggy #35

Closed
nbro opened this issue Jan 8, 2017 · 1 comment
Closed

TST's deletion is buggy #35

nbro opened this issue Jan 8, 2017 · 1 comment
Labels
bug An error in the source code.

Comments

@nbro
Copy link
Owner

nbro commented Jan 8, 2017

After visualizing the behaviour of a TST data structure using this tool, I realized that my implementation of deletion is buggy.

_delete_fix keeps deleting nodes up to the root and while u has no children, but it doesn't consider the fact that the current node u may contain a value and thus is not to be deleted.

This may not be the only problem... !! I need to think about all possible cases very well. Have a look at the implementation by galles.

@nbro nbro changed the title "Deletion" operation may not be implemented correctly "Deletion" operation may not be implemented correctly in TST Jan 8, 2017
@nbro nbro added help wanted question A single question regarding a particular topic/concept. labels Jan 9, 2017
@nbro nbro added the bug An error in the source code. label Jan 24, 2017
@nbro nbro changed the title "Deletion" operation may not be implemented correctly in TST TST's deletion is buggy Jan 24, 2017
@nbro nbro removed the question A single question regarding a particular topic/concept. label Jan 24, 2017
@nbro
Copy link
Owner Author

nbro commented Feb 2, 2017

The way the implementation of the TST of Galles works is slightly different than my implementation.

I think I solved the problem, but by modifying my function, rather than taking into consideration his implementation.

@nbro nbro closed this as completed Feb 2, 2017
@nbro nbro removed the help wanted label Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the source code.
Projects
None yet
Development

No branches or pull requests

1 participant