Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Building Docker Image #23

Closed
geekdave opened this issue Nov 1, 2017 · 4 comments
Closed

Error Building Docker Image #23

geekdave opened this issue Nov 1, 2017 · 4 comments

Comments

@geekdave
Copy link

geekdave commented Nov 1, 2017

Might just be a n00b mistake, but I'm getting this after a fresh clone on OSX:

❯ docker --version
Docker version 17.09.0-ce, build afdb6d4

❯ make docker
>> building docker image
Sending build context to Docker daemon  12.48MB
Step 1/6 : FROM golang
 ---> 59c0da3fc7cc
Step 2/6 : ADD . /go/src/github.com/ncabatoff/process-exporter
 ---> c3f532ec62a2
Step 3/6 : RUN make -C /go/src/github.com/ncabatoff/process-exporter
 ---> Running in 385e87743d56
make: Entering directory '/go/src/github.com/ncabatoff/process-exporter'
>> formatting code
>> vetting code
>> fetching promu
>> building binaries
 >   process-exporter
>> running short tests
?   	github.com/ncabatoff/process-exporter	[no test files]
?   	github.com/ncabatoff/process-exporter/cmd/process-exporter	[no test files]
ok  	github.com/ncabatoff/process-exporter/config	0.007s
--- FAIL: TestMissingIo (0.00s)
	read_test.go:160: got 0, want 1
FAIL
FAIL	github.com/ncabatoff/process-exporter/proc	0.007s
make: *** [test] Error 1
Makefile:36: recipe for target 'test' failed
make: Leaving directory '/go/src/github.com/ncabatoff/process-exporter'
The command '/bin/sh -c make -C /go/src/github.com/ncabatoff/process-exporter' returned a non-zero code: 2
make: *** [docker] Error 2
@dgmneto
Copy link

dgmneto commented Nov 22, 2017

I just got the same error.

@Sispheor
Copy link

Guys, don't use the master branch the last stable one

@ncabatoff
Copy link
Owner

Sorry about that, when I wrote the test that broke OSX builds I had a hunch it wasn't portable. Please re-open if you still have issues with master.

@ncabatoff
Copy link
Owner

My mistake, @flixr had properly identified the issue in his PR #24. Fix instead by only running TestMissingIo when we're not root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants