Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Custom redundancy tests can fail for basic algo #13

Closed
ncanceill opened this issue Oct 16, 2013 · 2 comments
Closed

Bug report: Custom redundancy tests can fail for basic algo #13

ncanceill opened this issue Oct 16, 2013 · 2 comments
Labels
Milestone

Comments

@ncanceill
Copy link
Owner

May be related to an improper check of the redundancy parameter, or to poor handling during operator selection.

Description

When running the tests, the basic algorithm with custom redundancy may fail due to not finding any valid TJ op.

How to reproduce

Use random seed b'^\xbe\xa1\x12V\xbf\xfd\xf3E\xb1\xf5\x84 x\xc1\x02' in tests.

@ncanceill
Copy link
Owner Author

This seed leads to a custom redundancy of 0.98, which does not leave enough space even in the test_long.pdf sample file.

@ncanceill
Copy link
Owner Author

test_long.pdf only has 1853 valid TJ operators, and the message requires 92 if nbits is 4, which is about 4,96%, so a redundancy of 0.98 is logically unacceptable.

A reasonable margin of error seems to be 0.85 in order to safely include nbits up to 8.

@ncanceill ncanceill mentioned this issue Oct 19, 2013
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant