Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to improve plot generation performance #209

Open
nusbaume opened this issue Sep 1, 2022 · 2 comments
Open

Need to improve plot generation performance #209

nusbaume opened this issue Sep 1, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request plotting Related to plot generation

Comments

@nusbaume
Copy link
Collaborator

nusbaume commented Sep 1, 2022

New feature type

New plot and/or plot enhancement, New infrastructure or infrastructure enhancement

What is this new feature?

During the AMP lunch meeting today, it was discussed how the plot generation step is by far the slowest feature in the ADF, and is currently the biggest reason why the ADF isn't as fast as the original AMWG diagnostics. Thus it would be good to see if there are some relatively easy-to-implement solutions that can be done now to try and speed-up that process, such as generating raster maps instead of the standard contour plots, or parallelizing the plotting scripts themselves similar to what is done for time series and climatology generation.

Assistance required?

No, I will make a PR when the feature is ready

Extra info

Any ideas are welcome! Just comment on this issue if you have anything to add. Thanks!

@nusbaume nusbaume added the enhancement New feature or request label Sep 1, 2022
@nusbaume nusbaume self-assigned this Sep 1, 2022
@nusbaume nusbaume added the plotting Related to plot generation label Sep 1, 2022
@justin-richling
Copy link
Collaborator

justin-richling commented Oct 27, 2022

For the polar plots, would it be worth looking into gdal or ncremap or other command line language to re-project the data before it gets to the plots? It seems we lose some time when re-projecting as the polar plots are being made in python.

@brianpm
Copy link
Collaborator

brianpm commented Dec 8, 2022

Do we have data to support the idea that plot generation is slower than NCL? I don't have a good feeling for what makes plotting fast or not. For contours and transforms, there could be actual algorithmic differences. I'm not sure if GDAL would save us from any of those calculations (I don't really understand GDAL). If all the time is being spent rendering (as opposed to calculating), I wonder whether there is a backend issue that could be customized to be faster (could be architecture dependent?)?

A couple things, just to remember to check:

Also, if we really get into this, we can explore non-Matplotlib options (e.g., plotly), but I'm not sure whether the mapping capabilities are as good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plotting Related to plot generation
Projects
None yet
Development

No branches or pull requests

3 participants