Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WRF sigma hybrid coordinate capability to DART #649

Closed
braczka opened this issue Mar 4, 2024 · 4 comments
Closed

Add WRF sigma hybrid coordinate capability to DART #649

braczka opened this issue Mar 4, 2024 · 4 comments
Assignees
Labels
wrf Weather Research & Forecasting Model

Comments

@braczka
Copy link
Contributor

braczka commented Mar 4, 2024

Describe the bug

Bug reported by Arthur Mizzi: "The bug is that DART is using the Terrain Following Vertical Coordinate (TFVC) system for WRF, and now WRF can use either a TFVC or a Hybrid Vertical Coordinate (HVC) system 1."

This change to WRF code occurred prior to WRF4 version. Recommended changes for DART code (WRF model_mod.f90) were included in a wrf_hybrid branch, but currently not included in main.

Another offline recommended fix provided from Chia-Hua Hsu WRF-Chem version of code also provided to DART team.

Error Message

Error message not provided

Which model(s) are you working with?

Sigma hybrid coordinate implemented prior to WRF4+ versions. DART change should be compatible with WRF3 and WRF4.

Version of DART

DARTv11.0.3

Have you modified the DART code?

Will implement portion of code within (https://github.com/nancycollins/DART/blob/wrf_hybrid/models/wrf/model_mod.f90) that targets sigma hybrid coordinate and verify it works.

@braczka braczka added the wrf Weather Research & Forecasting Model label Mar 4, 2024
@braczka braczka self-assigned this Mar 4, 2024
@hkershaw-brown
Copy link
Member

Is there detail on

Another offline recommended fix provided from Chia-Hua Hsu WRF-Chem version of code also provided to DART team.
what the bug/fix is?

@braczka
Copy link
Contributor Author

braczka commented Apr 5, 2024

Is there detail on

Another offline recommended fix provided from Chia-Hua Hsu WRF-Chem version of code also provided to DART team.
what the bug/fix is?

It's basically the same fix as included in the wrf_hybrid_branch, however the wrf_hybrid_branch fix works automatically -- it identifies if their are hybrid coordinates directly from the global attribute in the wrf file and applies the correct interpolation scheme, whereas the suggested offline fix, the user has to manually edit the source code to use the correct interpolation scheme, recompile etc.

@hkershaw-brown
Copy link
Member

gotcha, different fix for the same bug.

@hkershaw-brown
Copy link
Member

fixed in #650

hkershaw-brown added a commit that referenced this issue May 29, 2024
Latest from main, note keep wrf-wrf-chem version of wrf/model_mod.f90

note need to add #661 #649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wrf Weather Research & Forecasting Model
Projects
None yet
Development

No branches or pull requests

2 participants