Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

Don't add NaNs for _FillValue #31

Closed
matt-long opened this issue Jan 21, 2019 · 1 comment · Fixed by #34
Closed

Don't add NaNs for _FillValue #31

matt-long opened this issue Jan 21, 2019 · 1 comment · Fixed by #34

Comments

@matt-long
Copy link
Contributor

xarray sets a _FillValue = NaN on writing to file if the _FillValue field in encoding is not set. I think this is undesirable; the preferred behavior would be for the absence of _FillValue to be preserved.

This could be addressed in get_original_attrs by including something like the following.

    if '_FillValue' not in encoding:
        encoding['_FillValue'] = None
@andersy005
Copy link
Contributor

This is now fixed. Thank you for the pointer, @matt-long!

@andersy005 andersy005 added this to the sprint#1 milestone Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants