Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

jupyterlab_vim #42

Closed
matt-long opened this issue Sep 4, 2019 · 3 comments
Closed

jupyterlab_vim #42

matt-long opened this issue Sep 4, 2019 · 3 comments

Comments

@matt-long
Copy link
Contributor

Can we add https://github.com/jwkvam/jupyterlab-vim to post_build_base?

cc @brittstephens

@kmpaul
Copy link
Contributor

kmpaul commented Sep 9, 2019

If this gets installed, does this automatically change the key bindings for jupyterlab? Or is it something you can opt in/out?

@matt-long
Copy link
Contributor Author

@brittstephens, do you know the answer?

@kmpaul
Copy link
Contributor

kmpaul commented Sep 10, 2019

I've done some research on this. JupyterLab extensions are enabled at installation time. So, this would change the behavior for everyone, which is not desired.

You could install this extension and then disable it with:

jupyter labextension disable jupyterlab_vim

But then you'd have to go to the command line and execute:

jupyter labextension enable jupyterlab_vim

to enable it. However, requiring this is not much different than having the user install the extension themself. There are differences, though, which I enumerate below.

If you Install the extension and disable it, requiring the user enable it before use:

  1. the application (jupyter) does not need to be rebuilt when enabling the extension,
  2. whether it is enabled or disabled, it can conflict with other extensions that a use might install, and
  3. the user must execute the enable command from the command line.

If you require the user install the extension themself:

  1. the extension is downloaded and the application (jupyter) is rebuilt, albeit automatically,
  2. there is minimal risk of creating conflicts for users who choose not to use the extension, and
  3. the extension can be installed via the JupyterLab extension manage (from within the browser UI), without needing to execute any command-line commands.

Personally, I think that it makes sense not to install it and let users install it themselves.

The only advantage that I can see to doing this, rather than just asking the user to install the extension themselves (which they can do through JupyterLab's extension manager in the browser

@kmpaul kmpaul closed this as completed Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants