Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop option=1 issue for planting, harvesting, etc. #99

Open
cenlinhe opened this issue Oct 26, 2023 · 2 comments
Open

Crop option=1 issue for planting, harvesting, etc. #99

cenlinhe opened this issue Oct 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cenlinhe
Copy link
Collaborator

cenlinhe commented Oct 26, 2023

In the current Noah-MP, when crop option = 1, the parameters like planting date, harvesting date, and GDD are first assigned with the values from the NoahmpTABLE.TBL parameters:
https://github.com/NCAR/noahmp/blob/master/drivers/hrldas/BiochemVarInTransferMod.F90#L80
However, these parameters are then replaced by the variables from the crop static input file:
https://github.com/NCAR/noahmp/blob/master/drivers/hrldas/BiochemVarInTransferMod.F90#L125
So this makes the calibrated NoahmpTABLE.TBL table values for those parameters not used. Everytime, users want to calibrate these parameters, they have to change the input file values. Is this something designed by purpose initially or is this a bug? I also checked the version before v5.0, they have the same treatment.

@cenlinhe cenlinhe added bug Something isn't working development labels Oct 26, 2023
@tslin2
Copy link
Collaborator

tslin2 commented Oct 26, 2023

This seems to be an issue with single point and 2D regional simulations because these variables are not consistent for each grid cell. Perhaps the ideal model should read from a table for single point simulations but read from 2D input files (mainly from WPS) for regional simulations.

@tslin2
Copy link
Collaborator

tslin2 commented Oct 26, 2023

This is related to
#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants