Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd results in search #3

Closed
cmungall opened this issue May 23, 2017 · 3 comments
Closed

Odd results in search #3

cmungall opened this issue May 23, 2017 · 3 comments

Comments

@cmungall
Copy link
Member

Searching for stress disorder:

image

Note I seem to have all beacons selected:

image

In a distributed system we should be resilient to some beacons returning odd results. However, we still need to provide some kind of recommendations as to search behavior.

Also, we need to be able to see which beacon each search result is coming from

@goodb
Copy link

goodb commented May 23, 2017

I saw something similar. It seems that its looking for "stress" and "disorder" instead of "stress disorder" . I think this a bug in the API definition: "a (urlencoded) space delimited set of keywords or substrings against which to match concept names and synonyms"

Need to define how people should search for multi-string terms.

@RichardBruskiewich
Copy link
Collaborator

Yes, this issue relates to knowledge beacon implementation of the /concepts API call. Perhaps we need to clarify the intended semantics of the search, that hits should be returned in order of maximum number of keyword hits.
We've implemented a fix in the reference-beacon (http://beacon.medgeninformatics.net) to give this behaviour (works!) but other beacons will need to review this.
On the second issue of showing which beacon returns which research results, we are now working on that. We'll add a column for the CURIE (which will give the user feedback on beacon source and object identity) as well as, description (and fix a bug with semgroups). This should improve the interpretation of the results of the concept by text search. We'll deploy this as soon as it works!

@cmungall
Copy link
Member Author

Need to define how people should search for multi-string terms

It would be cool to aggregate results of different NER annotators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants