Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of json submissions fails with error: 'clinvarDeletion' is a required property #7

Closed
northwestwitch opened this issue Mar 14, 2024 · 1 comment

Comments

@northwestwitch
Copy link

Hello! I'm curating a repository that coverts text files submissions files (Variants and Casedata files - csv or tsv to json submission objects and I have some tests that started failing as soon as I've tried to update the ClinVar submission schema to the latest available on this repo.

The schema before worked just fine when I validated this json file but if I test it against the new schema I get this error:

'clinvarDeletion' is a required property

I've also tried validating the demo submission files you have uploaded yesterday under https://github.com/ncbi/clinvar/tree/master/submission_api_schema/sample_api_submissions

The validation of all these files fails with the same error.

I've just noticed that you are working on (possibly) another version of the API submission schema, so I'm wondering if I should keep the old schema in our software until a the new schema is available? How are the submissions impacted by this? I am pretty sure that our clinicians won't be able to submit anything using the API (because our software has a pre-validation against the API schema and the validation with the current schema always fails) so I'm keeping the old version for now..

Thanks in advance,
Chiara

@northwestwitch
Copy link
Author

northwestwitch commented Mar 14, 2024

Ok, when I test the validation of my demo submission file against the current schema using an external Json validator (https://www.jsonschemavalidator.net/) I see that it works, so I'm suspecting that my software might have some strict validation setting or something. I'll try to fix it. Closing this issue, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant