Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge develop to master, release v5.30.0 #153

Merged
merged 45 commits into from
May 3, 2024
Merged

Merge develop to master, release v5.30.0 #153

merged 45 commits into from
May 3, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented May 3, 2024

syphax-bouazzouni and others added 30 commits July 14, 2022 07:21
@syphax-bouazzouni
auto lint changes
13ad0fc
@syphax-bouazzouni
remove duplicated method
fac2795 
include_bnodes can also be found in the solution mapper
@syphax-bouazzouni
add the new function expand_equivalent_predicates_filter
8e52ba8
@syphax-bouazzouni
update get_includes to select :id, :attributeProperty, :attributeObject
f18548a
@syphax-bouazzouni
use the new get_includes
320a7ed
@syphax-bouazzouni
update the query builder to add the ?attributeProperty filters
1e3c164
@syphax-bouazzouni
update solutions_mapper to use the new pattern (?s,?p,?v,?inverse_v))
8a94793
@syphax-bouazzouni
update expand_equivalent_predicates
2022222
@syphax-bouazzouni
update get_predicate_map to predicate_map
7745e1f
@syphax-bouazzouni
update get_includes
d085508
@syphax-bouazzouni
update get_binding_as
95a3fea
@syphax-bouazzouni
update get_models_by_id_hash
72c6717
@syphax-bouazzouni
remove unused functions in the loader (an omission)
076420c
@syphax-bouazzouni
update get_embed_includes
2f8196e
@syphax-bouazzouni
add to the module loader `class << self to specify private functions
e312656
@syphax-bouazzouni
add properties_to_include to save the properties to include in the query
b222270
@syphax-bouazzouni
use the new get_includes, predicate_map and get_bnode_extraction
149a2e8
@syphax-bouazzouni
use the new expand_equivalent_predicates
5ea4f09
@syphax-bouazzouni
add in the query builder initialize instance variables
8028017
@syphax-bouazzouni
update the build_select_query
cf1d9ea
@syphax-bouazzouni
add to the solution mapper initialize some instance variable
a9161b4
@syphax-bouazzouni
update map_each_solutions
f4dc339
@syphax-bouazzouni
update order by query to use unions so that it can be optional
6cf7320
@syphax-bouazzouni
use optional statements for order by instead of UNION
dce68a7
@syphax-bouazzouni
fix embed ready only models
352f3ca
@syphax-bouazzouni
fix requests with multiple filters
3162ee8
@syphax-bouazzouni
use ontoportal-lirmm sparql client version to pass tests
1b26d2b
@alexskr
fix healthcheck for AG
87e991b
@mdorf
manually merged PR #124
1a6c63e
@mdorf
Merge branch 'ontoportal-lirmm-pr/feature/optimize-sparql-query-build…
c7ee4a6 
…-unions' into develop
syphax-bouazzouni and others added 15 commits April 17, 2024 17:19
@syphax-bouazzouni
add request store dependency to save globally the language per request
7215f49
@syphax-bouazzouni
and languages settings dsl
d6e8c33
@syphax-bouazzouni
create a module in sparql mixins to handle languages filters logic
163a3de
@syphax-bouazzouni
refactor query_builder to extract internal_variables as instance vari…
43c8459 
…able
@syphax-bouazzouni
add complex oder_by for embed attributes and fix empty pagination
0dc978a
@syphax-bouazzouni
add multilingual support tests
e72d643
@syphax-bouazzouni
update the lang filter module to include not tagged values if multipl…
a3d50fb 
…e languages selected
@syphax-bouazzouni
make map_attributes support multilingual
f34f2b0
@syphax-bouazzouni
unskip test_embed_struct
27fbe7d
@syphax-bouazzouni
add ruby-version file
eba6251
@syphax-bouazzouni
fix multilingual support for AG backend
fb04e78
@mdorf
Merge branch 'ontoportal-lirmm-pr/sync-agroportal-bioportal' into dev…
9fb8163 
…elop
@mdorf
Gemfile.lock update after merging #150
563a47f
@mdorf
Gemfile.lock update
5d911f5
@mdorf
Gemfile.lock update
33583fd
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.02985% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 87.05%. Comparing base (5caeb0d) to head (33583fd).
Report is 1 commits behind head on master.

Files Patch % Lines
lib/goo/sparql/solutions_mapper.rb 91.01% 16 Missing ⚠️
lib/goo/sparql/mixins/solution_lang_filter.rb 91.75% 8 Missing ⚠️
lib/goo/base/resource.rb 75.00% 6 Missing ⚠️
lib/goo.rb 61.53% 5 Missing ⚠️
lib/goo/sparql/query_builder.rb 97.23% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   84.53%   87.05%   +2.51%     
==========================================
  Files          35       36       +1     
  Lines        2516     2626     +110     
==========================================
+ Hits         2127     2286     +159     
+ Misses        389      340      -49
Flag Coverage Δ
unittests 87.05% <94.02%> (+2.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr marked this pull request as ready for review May 3, 2024 16:05
@alexskr alexskr merged commit 3a3f926 into master May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexskr @codecov-commenter @syphax-bouazzouni @mdorf