Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: ontology_submission.rb file to isolate the processing steps #143

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented May 19, 2022

Why

The current model ontologies_submission.rb (which represents the submission concept) contains more than 1500 lines, including in the same time the model information (its attributes e.g submissionId) and the model operations ( e.g parsing, diff, ...).

This PL isolates the different operations into separate modules. Making the ontologies_submission.rb file smaller (600 lines), easier to read and maintain

@syphax-bouazzouni syphax-bouazzouni changed the title Refactor ontology_submission.rb file to isolate the processing steps Refactor: ontology_submission.rb file to isolate the processing steps Sep 14, 2022
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Attention: Patch coverage is 67.50572% with 284 lines in your changes are missing coverage. Please review.

Project coverage is 78.21%. Comparing base (4dc3b11) to head (b09fd4e).

❗ Current head b09fd4e differs from pull request most recent head c879069. Consider uploading reports for the commit c879069 to get more accurate results

Files Patch % Lines
...ion_process/operations/submission_rdf_generator.rb 54.50% 187 Missing ⚠️
...ubmission_process/operations/submission_indexer.rb 59.83% 49 Missing ⚠️
...ocess/operations/submission_mertrics_calculator.rb 82.60% 12 Missing ⚠️
...on_process/operations/submission_diff_generator.rb 79.54% 9 Missing ⚠️
...rocess/operations/submission_properties_indexer.rb 82.60% 8 Missing ⚠️
lib/ontologies_linked_data/metrics/metrics.rb 57.14% 6 Missing ⚠️
...ervices/submission_process/submission_processor.rb 91.93% 5 Missing ⚠️
lib/ontologies_linked_data/diff/bubastis_diff.rb 80.00% 3 Missing ⚠️
lib/ontologies_linked_data/diff/diff.rb 57.14% 3 Missing ⚠️
...tologies_linked_data/models/ontology_submission.rb 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   80.07%   78.21%   -1.87%     
==========================================
  Files          65       72       +7     
  Lines        5003     5131     +128     
==========================================
+ Hits         4006     4013       +7     
- Misses        997     1118     +121     
Flag Coverage Δ
unittests 78.21% <67.50%> (-1.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mdorf added a commit that referenced this pull request Apr 24, 2024
mdorf added a commit that referenced this pull request Apr 24, 2024
@mdorf
Copy link
Member

mdorf commented Apr 24, 2024

manually merged this PR to https://github.com/ncbo/ontologies_linked_data/tree/develop

@alexskr
Copy link
Member

alexskr commented Apr 24, 2024

this PR overwrite metrics calculation changes introduced in #182. Those changes need to be re-applied.

@syphax-bouazzouni
Copy link
Author

Yes, this PR is too old, it needs to be updated.

@alexskr
Copy link
Member

alexskr commented Apr 25, 2024

this PR overwrite metrics calculation changes introduced in #182. Those changes need to be re-applied.

addressed in da1642e

@alexskr
Copy link
Member

alexskr commented Apr 29, 2024

manually merged

@alexskr alexskr closed this Apr 29, 2024
@syphax-bouazzouni
Copy link
Author

manually merged

OK great, keep me informed, If support is needed on this.

alexskr added a commit that referenced this pull request May 4, 2024
some of the changes introduced in PR #153 were rolled back by PR #143 merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants