Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warnings Redis#exists(key) will return an Integer in redis-rb 4.3 #3

Closed
alexskr opened this issue Jul 1, 2020 · 3 comments
Assignees

Comments

@alexskr
Copy link
Member

alexskr commented Jul 1, 2020

ncbo_cron logs shows deprecation warnings:
Redis#exists(key) will return an Integer in redis-rb 4.3. exists? returns a boolean, you should use it instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. To disable this message and keep the current (boolean) behaviour of 'exists' you can set Redis.exists_returns_integer = false, but this option will be removed in 5.0. (/srv/ncbo/ncbo_cron/vendor/bundle/ruby/2.6.0/bundler/gems/sparql-client-2ab48e2b7b2a/lib/sparql/client.rb:419:in `block in cache_invalidate_graph')

@mdorf
Copy link
Member

mdorf commented Jul 20, 2020

replaced: Redis#exists(key) with Redis#exists?(key)

@mdorf
Copy link
Member

mdorf commented Jul 21, 2020

This fix resulted in an failure to create a new submission. Since sparql-client itself does not import redis gem, it uses the redis object injected by the higher libraries. In this case, the redis version that was getting injected by the ontologies_api was 3.3.3, which does not define method exists?.

@mdorf mdorf reopened this Jul 21, 2020
mdorf added a commit to ncbo/ncbo_cron that referenced this issue Jul 21, 2020
mdorf added a commit to ncbo/ncbo_ontology_recommender that referenced this issue Jul 21, 2020
mdorf added a commit to ncbo/ontologies_api that referenced this issue Jul 21, 2020
mdorf added a commit to ncbo/ontologies_linked_data that referenced this issue Jul 21, 2020
@mdorf
Copy link
Member

mdorf commented Jul 21, 2020

fixed, deployed

syphax-bouazzouni added a commit to ontoportal-lirmm/ncbo_annotator that referenced this issue Feb 28, 2024
* Gemfile.lock update

* Gemfile.lock update; fixed ncbo/sparql-client#3

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* implemented #40 - Add incremental logging when the dictionary is being created

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Remove ffi gem version pin

* Gemfile.lock

* Gemfile.lock

* Gemfile.lock update

* pinned oj to v2.X for all projects due to an error in latest oj 3.13.1

* Gemfile.lock update

* Restore Gemfile.lock

Appears to have been accidentally deleted in the commit prior

* Pin faraday gem to 1.9

* Fix "same gem twice" parsing error

* Fix bundle install duplicate entry warnings

* Update Gemfile.lock

* Gemfile.lock update

* Update Gemfile.lock

* Update Gemfile.lock

* add docker support for unit testing

* remove wait-for-it

* add config file for testing

* Update branch specifier to develop

* remove deprecated ncbo_resource_index

* update ruby v2.6 -> 2.7

ncbo/bioportal-project#241

* ruby v2.7, bundler optimization - v2.3

* Reset branch specifier to develop

* Update Gemfile.lock

* Update Gemfile.lock

* Add Linux platform

* Update Gemfile.lock

* Fix - deprecation warning for pipelining commands on a Redis instance

Addresses #19
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

* Remove duplicated line

* Restore branch specifier to master

* Update Gemfile.lock

* Bump tzinfo from 0.3.60 to 0.3.61

Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 0.3.60 to 0.3.61.
- [Release notes](https://github.com/tzinfo/tzinfo/releases)
- [Changelog](https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md)
- [Commits](tzinfo/tzinfo@v0.3.60...v0.3.61)

---
updated-dependencies:
- dependency-name: tzinfo
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Reset branch specifier to develop

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile had references to develop branch

* Gemfile.lock update

* Allow setting ruby version in the docker-compose file

* Add codecov reporting

* fixed a failing unit test, test_annotate_minsize_term

* Gemfile.lock update

* Set mgrep default port to 55556

* gem version update

* fixed #26 - annotator cache generation failure - Unsupported command argument type: RDF::URI

* Gemfile.lock update

* bundle update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* Gemfile.lock update

* resolved an issue with the Recommender query in AllegroGraph

* an improved fix to ncbo/ncbo_ontology_recommender#21

* Add AllegroGraph backend to unit test matrix

* minitest style change for troubleshooting purposes

* Gemfile.lock update

* Gemfile.lock update

* update test CI

* add lemmatizer_jar config default value

* fix annotator after updating RDF version to 3.0

* update agraph version to 8.1.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: mdorf <mdorf@stanford.edu>
Co-authored-by: Alex Skrenchuk <alexskr@stanford.edu>
Co-authored-by: Jennifer Vendetti <vendetti@stanford.edu>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants